Skip to content

version: TRT upgrade to 9.2 on Linux Testing #2538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 18, 2024
Merged

version: TRT upgrade to 9.2 on Linux Testing #2538

merged 12 commits into from
Jan 18, 2024

Conversation

@gs-olive
Copy link
Contributor

Description

  • TRT version upgrade to 9.2

Fixes #2532

Type of change

  • Version upgrade

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive added the WIP Work is in progress, pull request should not be merged yet label Dec 13, 2023
@gs-olive gs-olive self-assigned this Dec 13, 2023
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: build system Issues re: Build system labels Dec 13, 2023
@github-actions github-actions bot requested a review from peri044 December 13, 2023 04:30
@gs-olive gs-olive force-pushed the trt_9_2 branch 3 times, most recently from c9ff362 to 3b48d80 Compare December 13, 2023 08:54
gs-olive
gs-olive commented Dec 13, 2023
View reviewed changes
Copy link
Contributor Author

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add TRT to LD library path after bazel install .tar.gz.

third_party/tensorrt/local/BUILD Outdated
static_library = select({
":aarch64_linux": "lib/aarch64-linux-gnu/libnvinfer_static.a",
":ci_rhel_x86_64_linux": "lib64/libnvinfer_static.a",
":ci_rhel_x86_64_linux": "targets/x86_64-linux-gnu/lib/libnvinfer_static.a",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RHEL 7 build. Pull container locally + install TRT + CUDNN.

pyproject.toml Outdated
"typing-extensions>=4.7.0",
"future>=0.18.3",
"tensorrt>=8.6,<8.7",
"tensorrt>=8.6",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specify <10.0

@gs-olive gs-olive force-pushed the trt_9_2 branch 5 times, most recently from 27bc6e0 to 215373f Compare December 14, 2023 01:12
@gs-olive gs-olive mentioned this pull request Dec 29, 2023
Closed
@gs-olive
Copy link
Contributor Author

  • Separate trt_9.2 branch rebase PR to

gs-olive
gs-olive commented Jan 17, 2024
View reviewed changes
packaging/pre_build_script.sh Outdated
Comment on lines 23 to 26
mkdir -p /usr/lib/aarch64-linux-gnu
cp /usr/tensorrt/targets/aarch64-linux-gnu/lib/* /usr/lib/aarch64-linux-gnu/ || :
mkdir -p /usr/include/aarch64-linux-gnu
cp /usr/tensorrt/targets/aarch64-linux-gnu/include/* /usr/include/aarch64-linux-gnu/ || :
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these for CI

@gs-olive gs-olive removed the WIP Work is in progress, pull request should not be merged yet label Jan 17, 2024
@gs-olive gs-olive changed the base branch from main to trt_9 January 17, 2024 23:58
@github-actions github-actions bot added the component: tests Issues re: Tests label Jan 18, 2024
@gs-olive gs-olive merged commit 45fcde7 into pytorch:trt_9 Jan 18, 2024
@gs-olive gs-olive deleted the trt_9_2 branch January 18, 2024 00:05
zewenli98 pushed a commit to zewenli98/TensorRT that referenced this pull request Mar 8, 2024
@gs-olive @zewenli98
version: TRT upgrade to 9.2 on Linux Testing (pytorch#2538)
2070e33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peri044 peri044 Awaiting requested review from peri044

Assignees

@gs-olive gs-olive

Labels

cla signed component: api [Python] Issues re: Python API component: build system Issues re: Build system component: tests Issues re: Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TRT Version Upgrade Investigation

2 participants

@gs-olive @facebook-github-bot